[alsa-devel] [PATCH 2/2] ASoC: cs4270: add Master Playback Switch

[Timur Tabi]

On Fri, Apr 24, 2009 at 9:37 AM, Daniel Mack <daniel at caiaq.de> wrote:
> This adds a new control named 'Master Playback Switch' for cs4270
> codecs. It is implemented using the new SOC_DOUBLE_EXT macro to catch
> the put function and store the information about manually set mute
> controls from userspace. When a manual mute is set, we don't want the
> soc core to un-mute the outputs.
>
> Renamed cs4270_mute() to cs4270_dai_mute() to avoid confusion.
>
> Signed-off-by: Daniel Mack <daniel at caiaq.de>
> Cc: Mark Brown <broonie at sirena.org.uk>
> Cc: Timur Tabi <timur at freescale.com>

Acked-by: Timur Tabi <timur at freescale.com>

However, ...

> @@ -486,7 +518,9 @@ static const struct snd_kcontrol_new cs4270_snd_controls[] = {
>        SOC_SINGLE("Zero Cross Switch", CS4270_TRANS, 5, 1, 0),
>        SOC_SINGLE("Popguard Switch", CS4270_MODE, 0, 1, 1),
>        SOC_SINGLE("Auto-Mute Switch", CS4270_MUTE, 5, 1, 0),
> -       SOC_DOUBLE("Master Capture Switch", CS4270_MUTE, 3, 4, 1, 1)
> +       SOC_DOUBLE("Master Capture Switch", CS4270_MUTE, 3, 4, 1, 1),
> +       SOC_DOUBLE_EXT("Master Playback Switch", CS4270_MUTE, 0, 1, 1, 1,
> +               snd_soc_get_volsw, cs4270_soc_put_mute)
>  };

Mark, could you add a comma at the end of "cs4270_soc_put_mute)" so
that any future patches won't need to delete any lines?

-- 
Timur Tabi
Linux kernel developer at Freescale