[alsa-devel] [PATCH v2 5/6] ARM: DaVinci: ASoC: Add machine driver support for DM646x

[Mark Brown]

On Thu, Apr 16, 2009 at 06:45:18PM -0400, Naresh Medisetty wrote:

> +static struct snd_soc_dai_link dm6467_evm_dai[] = {
> +	{
> +		.name = "TLV320AIC3X",
> +		.stream_name = "AIC3X",
> +		.cpu_dai = davinci_iis_mcasp_dai,

It'd be better to refer to the element in the array here.  It'd also be
better if your DAI driver provided constants which the machine drivers
could use to get the array indexes rather than hard coding them.

> +		.name = "MCASP S/PDIF",

McASP instead?  These names are mostly for human consumption.

> +/* davinci dm6467 evm audio machine driver */
> +static struct snd_soc_card dm6467_snd_soc_card_evm = {
> +		.name = "DaVinci DM6467 EVM",
> +		.platform = &davinci_soc_platform,
> +		.dai_link = dm6467_evm_dai,
> +		.num_links = 2,

ARRAY_SIZE().

>  /* evm audio private data */
>  static struct aic3x_setup_data evm_aic3x_setup = {
> -	.i2c_bus = 0,
> +	.i2c_bus = 1,
>  	.i2c_address = 0x1b,
>  };

This looks like a separate bug fix which should be split out and sent
for merge in 2.6.30?

>  static void __exit evm_exit(void)
>  {
>  	platform_device_unregister(evm_snd_device);
> +
>  }

Extra blank line added here.