[alsa-devel] [2.6.30-rc2][PATCH 2/2] ASoC: OMAP: Fix FS polarity in OSK5912 machine driver

[Arun KS]

On Wed, Apr 15, 2009 at 4:18 PM, Jarkko Nikula <jarkko.nikula at nokia.com> wrote:
> Using inverted FS polarity in OSK5912 must be an error since TLV320AIC23
> do not have support for inverted polarities. This is mostly due the hassle
> with the DSP formats in OMAP McBSP DAI and inversion on OMAP side probably
> just made this configuration working at some point.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula at nokia.com>
> Cc: Arun KS <arunks at mistralsolutions.com>
> ---
>  sound/soc/omap/osk5912.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/omap/osk5912.c b/sound/soc/omap/osk5912.c
> index a952a4e..a4e149b 100644
> --- a/sound/soc/omap/osk5912.c
> +++ b/sound/soc/omap/osk5912.c
> @@ -62,7 +62,7 @@ static int osk_hw_params(struct snd_pcm_substream *substream,
>        /* Set codec DAI configuration */
>        err = snd_soc_dai_set_fmt(codec_dai,
>                                  SND_SOC_DAIFMT_DSP_B |
> -                                 SND_SOC_DAIFMT_NB_IF |
> +                                 SND_SOC_DAIFMT_NB_NF |
>                                  SND_SOC_DAIFMT_CBM_CFM);
>        if (err < 0) {
>                printk(KERN_ERR "can't set codec DAI configuration\n");
> @@ -72,7 +72,7 @@ static int osk_hw_params(struct snd_pcm_substream *substream,
>        /* Set cpu DAI configuration */
>        err = snd_soc_dai_set_fmt(cpu_dai,
>                                  SND_SOC_DAIFMT_DSP_B |
> -                                 SND_SOC_DAIFMT_NB_IF |
> +                                 SND_SOC_DAIFMT_NB_NF |
>                                  SND_SOC_DAIFMT_CBM_CFM);
>        if (err < 0) {
>                printk(KERN_ERR "can't set cpu DAI configuration\n");
> --
> 1.6.2.1
Tested on osk5912.

Acked-by: Arun KS <arunks at mistralsolutions.com>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>