[alsa-devel] [PATCH 1/2] ASoC: omap-mcbsp: Correct the DSP_B mode

Jarkko Nikula jarkko.nikula at nokia.com
Tue Apr 14 14:49:00 CEST 2009


On Tue, 14 Apr 2009 14:32:30 +0200
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi at nokia.com> wrote:

> Should it be like this instead:
> + temp_fmt ^= SND_SOC_DAIFMT_NB_IF;
> 
Absolutely yes, good catch :-)

> 
> We only need to invert the FS polarity and the bclk should stay as it is..
> Also should than this modified fmt stored to mcbsp_data->fmt later?
> 
No since it's used only inside omap_mcbsp_dai_set_dai_fmt to tune polarity for the mode default. That's why there is this temp_fmt variable.


Jarkko


More information about the Alsa-devel mailing list