[alsa-devel] [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

Kumar Gala galak at kernel.crashing.org
Sun Apr 5 16:59:12 CEST 2009


On Apr 5, 2009, at 9:39 AM, Grant Likely wrote:

> On Sun, Apr 5, 2009 at 2:52 AM, Anton Vorontsov
> <avorontsov at ru.mvista.com> wrote:
>> On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote:
>>> Becky & Kumar,
>>>
>>> Considering these fixups, would it be advisable for the dma  
>>> functions
>>> to climb up the dev->parent linkage when dma_ops are NULL?
>>
>> pcm->dev->parent doesn't point to the proper device, so
>> this won't work.
>
> What does it point to then?  IIUC, following the ->parent links should
> eventually get to a struct device that represents the platform or
> of_platform device for purposes of power management.
>
> BTW, I'm not NAKing your patch.  The patch looks fine to me.
>
> g.

No, I think we should just fix drivers.  There aren't that many SoC  
drivers and once they are fixed this will resolve itself.

- k


More information about the Alsa-devel mailing list