[alsa-devel] [PATCH - alsa-utils 2/2] alsamixer - unified behavior of volume keys for left & right levels.

Simon Hengel simon.hengel at gmx.net
Thu Apr 2 18:05:30 CEST 2009


Contrary to what is documented 'q', 'e', 'z' and 'c' did different
things as there upper case counterparts. The lower case versions
changed volume by 2%, whereas the upper case commands changed volume by
1%.

Now all of them change the volume by only 1%.

Signed-off-by: Simon Hengel <simon.hengel at gmx.net>

diff --git a/alsamixer/alsamixer.c b/alsamixer/alsamixer.c
index 554326f..51cd97e 100644
--- a/alsamixer/alsamixer.c
+++ b/alsamixer/alsamixer.c
@@ -2187,26 +2187,22 @@ mixer_iteration (void)
 	mixer_volume_absolute = 10 * (key - '0');
 	break;
       case 'q':
-	mixer_volume_delta[MIXER_CHN_LEFT] = 1;
       case 'Q':
-	mixer_volume_delta[MIXER_CHN_LEFT] += 1;
+	mixer_volume_delta[MIXER_CHN_LEFT] = 1;
 	break;
       case 'y':
       case 'z':
-	mixer_volume_delta[MIXER_CHN_LEFT] = -1;
       case 'Y':
       case 'Z':
-	mixer_volume_delta[MIXER_CHN_LEFT] += -1;
+	mixer_volume_delta[MIXER_CHN_LEFT] = -1;
 	break;
       case 'e':
-	mixer_volume_delta[MIXER_CHN_RIGHT] = 1;
       case 'E':
-	mixer_volume_delta[MIXER_CHN_RIGHT] += 1;
+	mixer_volume_delta[MIXER_CHN_RIGHT] = 1;
 	break;
       case 'c':
-	mixer_volume_delta[MIXER_CHN_RIGHT] = -1;
       case 'C':
-	mixer_volume_delta[MIXER_CHN_RIGHT] += -1;
+	mixer_volume_delta[MIXER_CHN_RIGHT] = -1;
 	break;
       case 'm':
       case 'M':
-- 
1.5.6.3



More information about the Alsa-devel mailing list