[alsa-devel] [PATCH 2/5] Separate common pxa2xx-ac97 code
Liam Girdwood
lrg at kernel.org
Mon Sep 8 11:51:37 CEST 2008
On Mon, 2008-09-08 at 09:42 +0000, Dmitry Baryshkov wrote:
> Liam Girdwood wrote:
>
> > On Mon, 2008-09-08 at 13:06 +0400, Dmitry Baryshkov wrote:
> >> ASoC and non-ASoC drivers for ACLINK on PXA share lot's of common code.
> >> Move all common code into separate file.
> >>
> >> +#include "pxa2xx-ac97-lib.c"
> >>
> >>
> > Any reason for not linking with pxa2xx-ac97-lib.o ?
> >
>
> >> +#include "../../arm/pxa2xx-ac97-lib.c"
> >
> >
> > ditto
> >
> >> static void pxa2xx_ac97_warm_reset(struct snd_ac97 *ac97) {
> >
> > Liam
>
>
> That is the interim change. In the next patch the file is fully separated
> into distinct module. I can squash those patches if you'd prefer.
>
>
Yes, please - makes it easier to read.
Liam
More information about the Alsa-devel
mailing list