[alsa-devel] [PATCH 2/4] SOUND: SOC: CODECS: Add support for the TWL4030 audio codec

[Liam Girdwood]

On Tue, 2008-09-02 at 19:54 +0100, Mark Brown wrote:
> On Tue, Sep 02, 2008 at 09:36:29AM -0700, Steve Sakoman wrote:
> 
> > The chip allows 19.2 Mhz, 26 Mhz, or 38.4 Mhz input clocks to the
> > codec.  All existing boards (Overo, Beagle, and OMAP3 EVM) use 26 Mhz
> > (generated by a fixed external oscillator chip).  I'll check with the
> > Pandora folks, but I believe that they are also 26 Mhz.
> 
> OK, a comment to that effect somewhere (perhaps in set_sysclk() which
> only accepts 26MHz) probably wouldn't go amiss.

The codec set_sysclk() should also accept 19.2MHz and 38.4MHz otherwise
return -EINVAL. It should also have a nice comment too :)

Strange how the codec doesn't accept lower clocks when it's targeted at
a portable device....

Liam