[alsa-devel] [PATCH] ASoC: Convert tlv320aic3x to a new-style i2c driver

Jean Delvare khali at linux-fr.org
Mon Sep 1 14:27:26 CEST 2008


On Mon, 1 Sep 2008 15:20:38 +0300, Jarkko Nikula wrote:
> On Mon, 1 Sep 2008 12:35:09 +0100
> "ext Mark Brown" <broonie at sirena.org.uk> wrote:
> 
> > On Mon, Sep 01, 2008 at 02:31:14PM +0300, Jarkko Nikula wrote:
> > > "ext Jean Delvare" <khali at linux-fr.org> wrote:
> > 
> > > Thanks. In N810 it's connected into second i2c bus so this makes it
> > > working
> > 
> > >  +	.i2c_bus = 2,
> > 
> > Should that be 1?  Normally the buses are numbered from zero...
> >
> Good question. By some historical reason we are registering busses
> starting from number one in OMAP and short hack below (in linux-omap
> tree) trying to register them starting from zero didn't work out.
> 
> But yeah, that's another issue in linux-omap and Jean's patch is
> working on N810 if changing this i2c_bus to 2.

OK, thanks Jarkko for testing and reporting. I'll make it 2 for the
time being so that things keep working, and it can be changed later if
needed.

-- 
Jean Delvare


More information about the Alsa-devel mailing list