[alsa-devel] [PATCH] Automatically use ALC268_TOSHIBA for Toshiba L305 Laptop

[Takashi Iwai]

At Sat, 30 Aug 2008 04:51:04 +1000,
Travis Place wrote:
> 
> Changelog: Added Subsystem IDs (0x1179, 0xff64) for the Toshiba Satellite L305 
> laptop, so it automatically uses the ALC268_TOSHIBA quirk.
> 
> Signed-off-by: Travis Place <wishie at wishie.net>

Thanks, applied.


BTW, one your patch was reverted recently due to regression on 2.6.27:

    Revert "ALSA: hda - Added model selection for iMac 24""

    This reverts commit 3e0e469fa216ec70c93b1593821b759d19ee2e6b.

    The patch introduced a wrong detection of other intel Macs with
    ALC88* codec because they share the same PCI SSID (but have different
    codec subsystem-IDs).  See http://lkml.org/lkml/2008/8/24/143

    Reported-and-tested-by: Guillaume Chazarain <guichaz at gmail.com>
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

Do you know the pointer (alsa-info.sh or such) of the original
problem?  We need to add codec SSID check instead of PCI SSID for this
hardware.


thanks,

Takashi


> 
> Patch Attached.
> 
> Thanks,
> Travis Place (wishie)
> [2 patch_realtek.c.patch <text/x-diff; us-ascii (7bit)>]
> --- patch_realtek.c.orig	2008-08-30 04:45:43.000000000 +1000
> +++ patch_realtek.c	2008-08-30 04:47:21.000000000 +1000
> @@ -11447,6 +11447,7 @@
>  	SND_PCI_QUIRK(0x1043, 0x1205, "ASUS W7J", ALC268_3ST),
>  	SND_PCI_QUIRK(0x1179, 0xff10, "TOSHIBA A205", ALC268_TOSHIBA),
>  	SND_PCI_QUIRK(0x1179, 0xff50, "TOSHIBA A305", ALC268_TOSHIBA),
> +	SND_PCI_QUIRK(0x1179, 0xff64, "TOSHIBA L305", ALC268_TOSHIBA),
>  	SND_PCI_QUIRK(0x14c0, 0x0025, "COMPAL IFL90/JFL-92", ALC268_TOSHIBA),
>  	SND_PCI_QUIRK(0x152d, 0x0763, "Diverse (CPR2000)", ALC268_ACER),
>  	SND_PCI_QUIRK(0x152d, 0x0771, "Quanta IL1", ALC267_QUANTA_IL1),