[alsa-devel] [PATCH2/4] hda: dynamic jack id

Mark Brown broonie at sirena.org.uk
Tue Oct 21 21:41:37 CEST 2008


On Tue, Oct 21, 2008 at 01:26:48PM -0400, Matthew Ranostay wrote:
> Allow jack->id to be kstrdup()'ed to prevent scope issues from
> calling functions.

Your patch doesn't allow it to be duplicated - it does actually
duplicate it.  Do you mean to say that you want to duplicate the string
so that users can automatically generate the string without having to
manage the memory for it?

That should be OK for the embedded case, the size of the string isn't
such a big deal if you're able to handle a reasonable amount of audio
data, and it's probably going to be a common case with autoprobable
things like HDA.

I'd prefer a clearer changelog but:

Acked-by: Mark Brown <broonie at opensource.wolfsonmicro.com>


More information about the Alsa-devel mailing list