[alsa-devel] [PATCH1/2] hda: add access to jack functions

[Takashi Iwai]

At Mon, 20 Oct 2008 17:40:08 -0400,
Matthew Ranostay wrote:
> 
> Removed 'static' declaration from get_jack_location() to be accessed via the
> codec patches. Also added jack location and type reporting functions for use in
> the jack abstraction layer implementations.
> 
> Signed-off-by: Matthew Ranostay <mranostay at embeddedalley.com>
> ---
> 
> diff --git a/sound/pci/hda/hda_local.h b/sound/pci/hda/hda_local.h
> index 4a08c31..10f26e0 100644
> --- a/sound/pci/hda/hda_local.h
> +++ b/sound/pci/hda/hda_local.h
> @@ -383,6 +383,9 @@ int snd_hda_parse_pin_def_config(struct hda_codec *codec,
>  /*
>   * get widget capabilities
>   */
> +const char *get_jack_connectivity(u32 cfg);
> +const char *get_jack_type(u32 cfg);
> +const char *get_jack_location(u32 cfg);

Basically all global functions should have snd_ prefix.
Yeah, get_wcaps() has exceptionally no prefix but it's an inline
function.

Also, if these function are really needed in patch_*.c, they must be
moved to hda_codec.c since the build of hda_proc.c depends on
CONFIG_PROC_FS.


thanks,

Takashi