[alsa-devel] [PATCH] snd-sbxfi: implement Master volume control

Takashi Iwai tiwai at suse.de
Mon Oct 20 10:57:31 CEST 2008

At Mon, 20 Oct 2008 07:59:32 +0200,
I wrote:
> At Sun, 19 Oct 2008 18:08:15 -0500,
> William Pitcock wrote:
> > 
> > Unfortunately, the X-Fi does not have a hardware master volume control, so we have
> > to create a virtual master and bind all playback controls to it.
> > 
> > This patch depends on the patch that renames Master to PCM.
> > 
> > Signed-off-by: William Pitcock <nenolod at sacredspiral.co.uk>
> I don't like this patch because the virtual master implementation is
> already found in sbxfi.c  No reason to use yet another vmaster
> framework in addition.
> So, no I don't apply both patches.  A simpler fix is just to add PCM
> volume like Master volume.  Both can use the same callbacks, so the
> addition would be pretty small.

I added PCM volume now using the same mechanism as Master volume.
Please give it a try, and let me know if it's broken.



More information about the Alsa-devel mailing list