[alsa-devel] [PATCH] hda: add support for jack detection on IDT/Sigmatel

Takashi Iwai tiwai at suse.de
Wed Oct 15 17:47:05 CEST 2008


At Wed, 15 Oct 2008 16:44:02 +0100,
Mark Brown wrote:
> 
> > +	if (codec->jack)
> > +		snd_jack_report(codec->jack,
> > +			presence ? SND_JACK_HEADPHONE : 0);
> > +
> 
> Since you appear to fail init if you can't create the jack there should
> be no need to check for the jack being initialised here.  For ease of
> use I'll just submit a patch folding that check into snd_jack_report(),
> though.

Such a change can go to 2.6.28, too, if received timely :)


Takashi


More information about the Alsa-devel mailing list