[alsa-devel] [PATCH 1/1] [ALSA] Allow setting codec register with debugfs filesystem

[Mark Brown]

On Mon, Oct 13, 2008 at 05:42:14PM -0700, Troy Kisky wrote:

Thanks.

> @@ -425,6 +425,7 @@ struct snd_soc_codec {
>  	short reg_cache_step;
>  
>  	/* dapm */
> +	u32 pop_time;
>  	struct list_head dapm_widgets;

Hrm.  On the one hand this is deliberately a system-wide bit of
configuration since the pop/click sequencing covers the whole system
rather than just the codec.  On the other hand the codec structure does,
unfortunately, represent the entire sound device currently.  I'll have a
think and either push the patch as-is or push it together with a
followup patch moving the pop time configuration out of the codec
structure.

> +}
> +
>  static DEVICE_ATTR(codec_reg, 0444, codec_reg_show, NULL);

Extra blank line added here.

> +	file = debugfs_create_file("codec_reg", 0644,
> +			root, socdev, &codec_reg_fops);
> +	if (!file)
> +		goto exit2;
> +
> +	file = debugfs_create_u32("dapm_pop_time", 0744,
> +			root, &codec->pop_time);
> +	if (!file)
> +		goto exit2;

There's no real need to handle these errors - if anything, it's probably
better to half create the tree 

> +exit1:
> +	dev_err(socdev->dev, "debugfs is not available\n");
> +}

This isn't actually an error...