[alsa-devel] [PATCH] ASoC: Hide TLV320AIC26 configuration option for non-OpenFirwmare users

Mark Brown broonie at opensource.wolfsonmicro.com
Mon Oct 13 20:14:58 CEST 2008

On Mon, Oct 13, 2008 at 07:33:01PM +0200, Takashi Iwai wrote:

> Hmm, I'm afraid this may disable CONFIG_SND_SOC_TLV320AIC26 when
> CONFIG_SND_SOC_OF_SIMPLE=n automatically, no?

Yes, I'd feared that too but it doesn't do that, at least not in my
testing - the dependencies are just completely ignored.

> > Thanks to Takashi for the suggestion.

> Actually I proposed a wrong solution.  What I meant was the form using
> "if" instead of "depends on":

> config SND_SOC_TLV320AIC26
>  	tristate "TI TLV320AIC26 Codec support" if SND_SOC_OF_SIMPLE
> 	...

> In this way, the selectable item appears only when
> CONFIG_SND_SOC_OF_SIMPLE is set.  The other dependencies remain as
> they are.

Ah, yes.  That seems to work too and is a bit neater, though still a bit
nasty since it looks like the tristate is conditional on the
OpenFirmware support now so it's still not entirely clear that the right
thing will happen.  Updated patch coming in a moment.

More information about the Alsa-devel mailing list