[alsa-devel] Backported sbxfi driver (UNTESTED!)

[Takashi Iwai]

At Mon, 13 Oct 2008 18:33:48 +0400,
The Source wrote:
> 
> Takashi Iwai пишет:
> > At Mon, 13 Oct 2008 16:58:05 +0400,
> > Alexey Bazhin wrote:
> >   
> >> On Mon, 13 Oct 2008 04:03:34 +0200
> >> Takashi Iwai <tiwai at suse.de> wrote:
> >>
> >>     
> >>> At Sun, 12 Oct 2008 16:53:53 +0400,
> >>> Alexey Bazhin wrote:
> >>>       
> >>>> Hi,
> >>>>
> >>>> I have just compiled driver from git and try to run it. My card is
> >>>> pci: 1102:0005 Multimedia audio controller: Creative Labs SB X-Fi
> >>>>
> >>>> I got following:
> >>>>
> >>>> root at mayonaka:~# modprobe snd-sbxfi
> >>>> root at mayonaka:~# speaker-test -c 2 -r 96000 -t sine
> >>>>
> >>>> speaker-test 1.0.15
> >>>>
> >>>> Playback device is default
> >>>> Stream parameters are 96000Hz, S16_LE, 2 channels
> >>>> Sine wave rate is 440.0000Hz
> >>>> Rate set to 96000Hz (requested 96000Hz)
> >>>> [  262.522739] XFi DAC reset timeout
> >>>>
> >>>> Period size ran[  262.564029] XFi DAC reset timeout
> >>>> ge from 32 to 16[  262.620275] XFi DAC reset timeout
> >>>> 384
> >>>> Using max b[  262.676529] XFi DAC reset timeout
> >>>> uffer size 16384[  262.732784] XFi DAC reset timeout
> >>>>
> >>>> Periods = 4
> >>>> w[  262.789038] XFi DAC reset timeout
> >>>> as set period_size = 4096
> >>>> was set buffer_size = 16384
> >>>>  0 - Front Left
> >>>> [  327.491997] BUG: soft lockup - CPU#0 stuck for 61s! [swapper:0]
> >>>> [  327.492001] Kernel panic - not syncing: softlockup: hung tasks
> >>>>
> >>>> and i did hear the sine on the left channel. Hope it helps...
> >>>>         
> >>> Try the very latest sound-unstable tree.  Some fixes are there...
> >>>       
> >> Without debug i got the same, with debug my box freezed without
> >> panic, i'l reset it when i get home and will try it again...
> >>     
> >
> > Try the latest version.  Another fix was there.
> >
> >
> > Takashi
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel at alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
> >   
> 
> Tried today's snapshot for my card (X-Fi Fatality Champion Series). No 
> change.

Does the patch below already in your snapshot tarball?
Otherwise it's an older version.

> alsamixer shows only master and mic-boots for playback.

This is no bug.  It is so.  The OSS drivers doesn't provide more than
that, and thus mine, too.

> Any 
> attempt to use sound with alsa (aplay, any app that uses sound) results 
> in reboot.

This must be fixed, of course.  And I hoped that was the patch below.


Takashi

===
commit 80e25366431dd8a4481880d34072cd8de3c17376
Author: Takashi Iwai <tiwai at suse.de>
Date:   Mon Oct 13 03:59:45 2008 +0200

    sbxfi - fix spinlock again
    
    The last fix was broken; one shouldn't work on Sunday, really.
    
    Signed-off-by: Takashi Iwai <tiwai at suse.de>

diff --git a/sound/pci/sbxfi/sbxfi.c b/sound/pci/sbxfi/sbxfi.c
index f4e8da1..39dfd9e 100644
--- a/sound/pci/sbxfi/sbxfi.c
+++ b/sound/pci/sbxfi/sbxfi.c
@@ -356,10 +356,10 @@ static irqreturn_t sbxfi_interrupt(int irq, void *dev_id)
 			spin_unlock(&chip->timer_lock);
 			if (update)
 				sbxfi_check_period_update(chip);
-			spin_unlock(&chip->timer_lock);
+			spin_lock(&chip->timer_lock);
 		} while (chip->timer_reprogram);
 		chip->irq_handling = 0;
-		spin_lock(&chip->timer_lock);
+		spin_unlock(&chip->timer_lock);
 	}
 
 	/* ack */