[alsa-devel] Backported sbxfi driver (UNTESTED!)

[William Pitcock]

With this patch, the driver does output audio, but the DAC dies and we
only get noise. Going to try to whack at this with a larger hammer, it's
a fairly obvious bug, it just needs some debugging. The noise sounds
like the write pointer is off-by-one; it sort of resembles the source
audio.

Some patches for mixer stuff are coming soon (next few hours
probably)... as well as chip revision detection and some other
niceities.

William

On Fri, 2008-10-10 at 08:46 +0200, Takashi Iwai wrote:
> At Fri, 10 Oct 2008 01:26:15 -0500,
> Ted T. Logian wrote:
> > 
> > 
> > 
> > On Fri, 2008-10-10 at 08:01 +0200, Takashi Iwai wrote:
> > > At Thu, 09 Oct 2008 15:17:58 -0500,
> > > Ted T. Logian wrote:
> > > > 
> > > > Sorry for the multiple posts, but once I rmmod snd-sbxfi, running mixer does
> > > > fine.  It seems if I have snd-sbxfi loaded and I run alsamixer, it locks the
> > > > entire system.
> > > 
> > > So, do you mean loading the driver itself doesn't lock up?  If so,
> > > it's better than I expected.
> > > 
> > > Did you run ever PCM playback/capture before that?  This is more
> > > dangerous :)
> > > 
> > > Also, please give your hardware details, as there are different models
> > > for X-Fi, and some are handled pretty differently.
> > > 
> > > [BTW, please stop top-posting, and avoid HTML mails for ML.  It's easy
> > >  to switch to normal (plain) mail mode on Gmail, just a click.]
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > 
> > 
> > I think perhaps from uninstalling pulseaudio I got further.  I can use
> > mixer now, and it even has a "Master" device, but nothing else...
> > 
> > however, I do get a lock up later.
> > 
> > I get this from running aplay, too, if this helps...
> 
> Thanks!  That's rather a stupid bug.
> The patch is below.
> 
> 
> Takashi
> 
> diff --git a/sound/pci/sbxfi/sbxfi.c b/sound/pci/sbxfi/sbxfi.c
> index 8066bf4..8a0eea0 100644
> --- a/sound/pci/sbxfi/sbxfi.c
> +++ b/sound/pci/sbxfi/sbxfi.c
> @@ -831,7 +831,7 @@ static struct sbxfi_port *sbxfi_port_alloc(struct sbxfi *chip,
>  	port->src[0] = src;
>  	port->src[1] = src + 1;
>  	spin_lock_irq(&chip->port_lock);
> -	list_add(&chip->port_list, &port->list);
> +	list_add(&port->list, &chip->port_list);
>  	spin_unlock_irq(&chip->port_lock);
>  	return port;
>  }
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20081010/188e1253/attachment.sig