[alsa-devel] [PATCH 2.6.27?] ASoC: Correct inverted Mic PGA Switch control in wm8510 driver

Troy Kisky troy.kisky at boundarydevices.com
Fri Oct 3 19:20:53 CEST 2008


Mark Brown wrote:
> Mic PGA Switch should be inverted in the WM8510 driver but isn't.
> 
> Reported-by: ext-jukka.hynninen at vaisala.com
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
> ---
> 
> This bugfix applies to 2.6.27 but the issue is not very severe - it'd be
> good to get it in but it's not critical.
> 
>  sound/soc/codecs/wm8510.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c
> index 75ed041..f644da6 100644
> --- a/sound/soc/codecs/wm8510.c
> +++ b/sound/soc/codecs/wm8510.c
> @@ -199,7 +199,7 @@ SOC_DAPM_SINGLE("PCM Playback Switch", WM8510_MONOMIX, 0, 1, 0),
>  };
>  
>  static const struct snd_kcontrol_new wm8510_boost_controls[] = {
> -SOC_DAPM_SINGLE("Mic PGA Switch", WM8510_INPPGA,  6, 1, 0),
> +SOC_DAPM_SINGLE("Mic PGA Switch", WM8509_INPPGA,  6, 1, 1),
>  SOC_DAPM_SINGLE("Aux Volume", WM8510_ADCBOOST, 0, 7, 0),
>  SOC_DAPM_SINGLE("Mic Volume", WM8510_ADCBOOST, 4, 7, 0),
>  };

Why the WM509 prefix instead of WM8510?



More information about the Alsa-devel mailing list