[alsa-devel] [PATCH] cleanup controllers in snd-usb-caiaq
Daniel Mack
daniel at caiaq.org
Wed Nov 26 19:57:20 CET 2008
Hi Takashi,
On Wed, Nov 26, 2008 at 04:44:08PM +0100, Takashi Iwai wrote:
> > this patch does some code cleanup in snd-usb-caiaq. No functional change
> > whatsoever. Version number bumped to 1.3.9.
>
> A macro for such is ugly and potentially dangerous, IMO.
> Make a function instead.
>
> Also, please add an error check of the return value from
> snd_ctl_add().
Ok, agreed and done. However, I considered it a good idea as it avoided
writing the array's name more than once.
Daniel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: caiaq-controls-cleanup.diff
Type: text/x-diff
Size: 3832 bytes
Desc: not available
Url : http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20081126/b305ec5d/attachment.bin
More information about the Alsa-devel
mailing list