[alsa-devel] [PATCH] OMAP general SOC driver.

[Jarkko Nikula]

On Wed, 26 Nov 2008 11:08:55 +0000
"ext Mark Brown" <broonie at sirena.org.uk> wrote:

> > +#ifdef CONFIG_SND_OMAP_SOC_N810
> > +#include "../codecs/tlv320aic3x.h"
> > +#define CODEC_SYS_CLOCK		12000000
> > +#define CODEC_NAME		"TLV320AIC33"
> > +#define STREAM_NAME		"AIC33"
> > +#define CODEC_DEV		(&soc_codec_dev_aic3x)
> > +#define CODEC_DAI		(&aic3x_dai)
> > +#define CODEC_SETUP_DATA	(&&n810_aic33_setup)
> > +#define DAI_LINK_INIT		(n810_aic33_init)
> > +#define SOC_OPS_STARTUP		(n810_startup)
> > +#define SOC_OPS_SHUTDOWN	(n810_shutdown)
> 
> Please change this to use a platform data based approach rather than
> these ifdefs: it's not a good approach for readability and it prevents
> building multiple board drivers in one kernel which isn't good for
> distributions.  The s3c24xx_uda134x.c provides an example of how this
> can be done.  It may be more sensible to have a separate driver per
> codec.
> --
And as a first step, I recommend to start merging only those EVM & SDP
boards with Beagle since they seems to be most close to each other.

Even the Overo seems to be close also, it was discussed earlier to keep
it separated now since Steve was going to send some new features into
it.


Jarkko