[alsa-devel] [Bulk] Re: [PATCH] Added Realtek ALC888 model entry for the Acer Aspire 4930G laptop

[Takashi Iwai]

At Tue, 18 Nov 2008 21:13:53 +0800,
Vincent Petry wrote:
> 
> Hello Takashi,
> 
> I have updated the patch to make it work with your changes and tested
> it. I also updated the code style.

Thanks for a quick fix!

> +static struct hda_input_mux alc888_acer_aspire_4930g_capture_source[2] = {
> +	{
> +		.num_items = 3,
> +		.items = {
> +			{ "Mic", 0x0 },
> +			{ "Line", 0x2 },
> +			{ "CD", 0x4 },
> +		},
> +	},
> +	/* Front mic only available on second ADC */

Well... I think we should stick with the single ADC (only using 2nd
ADC) if the front mic isn't available with the 1st ADC.
The first ADC is used as the primary stream, and people would wonder
when they can't record from the front/internal mic.

Or, you can exchange the first and second ADCs so that the second ADC
is used for the primary purpose and the less-functional ADC can be
still used parallel as an alternative stream (via hw:0,2).

Also, don't forget to add your new model to
Documentation/*/ALSA-Configuration.txt.

Otherwise the patch looks good.
Could you fix the above and repost?


thanks,

Takashi