[alsa-devel] [PATCH] hda: alc883 model for ASUS P5Q-EM boards

[Takashi Iwai]

At Mon, 17 Nov 2008 08:50:38 +0800,
Wu Fengguang wrote:
> 
> On Sun, Nov 16, 2008 at 12:45:12PM -0500, Andrei Tanas wrote:
> > > > How did you find out that it's 0x10 instead of 0x06? Has
> > > documentation on
> > > > ALC1200 become available?
> > > 
> > > It's easy:
> > > grep -i -C6 spdif /proc/asound/card0/codec\#0
> > > grep -i -C6 'stereo digital' /proc/asound/card0/codec\#0
> > > 
> > > And check the connectivity between pin complex and audio output nodes.
> > That's the kind of stuff that would be great to know for somebody who wants
> > to troubleshoot something for the first time. Thanks.
> 
> You are welcome.
> 
> > > Now you can do a 'cat /proc/asound/card0/codec\#1' and read about the
> > > HDMI codec. For it to work, you may need the bleeding edge Xorg
> > > drivers.
> > That will be for somebody else to test I guess, I don't have the hardware -
> > it turns out my TV does not take digital audio through its HDMI port.
> 
> That's fine.
> 
> The G45 HDMI has worked on our boards, so chances are good for others.
> 
> > > So let's create a new model?
> > I should have gave it a shot myself I guess.
> > 
> > > +#define ALC883_DIGOUT_NID_ASUS_P5Q	0x10
> > Why not ALC1200_DIGOUT_NID? Or is it really specific to Asus P5Q?
> 
> I'm not really sure, but ALC1200_DIGOUT_NID does look like a better name :-)
> 
> > The patch worked perfectly.
> 
> Thank you.
> 
> Fengguang
> ---
> 
> hda: alc883 model for ASUS P5Q-EM boards
> 
> Add a new alc883 model ALC1200_ASUS_P5Q for ASUS P5Q-EM boards.
> It is the same as ALC883_6ST_DIG except that the SPDIF digital
> output nid is 0x10.
> 
> Tested-by: Andrei Tanas <andrei at tanas.ca>
> Signed-off-by: Wu Fengguang <wfg at linux.intel.com>

Applied now.  Thanks.


Takashi