[alsa-devel] [PATCH] ASoC: Fix for master playback/capture volume range for TWL4030 codec

Mark Brown broonie at sirena.org.uk
Fri Nov 14 11:11:22 CET 2008


On Fri, Nov 14, 2008 at 08:57:28AM +0200, Peter Ujfalusi wrote:
> FGAIN for playback is in range of 0-0x3f, while for capture GAIN it
> is in the range of 0-0x1f.
> The original value of 128 (0x7f) would modify the CGAIN also for
> playback.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi at nokia.com>

CCing in Steve Sakoman who wrote the driver.

> ---
>  sound/soc/codecs/twl4030.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
> index 90f3b4d..65aeabe 100644
> --- a/sound/soc/codecs/twl4030.c
> +++ b/sound/soc/codecs/twl4030.c
> @@ -192,10 +192,10 @@ static void twl4030_init_chip(struct snd_soc_codec *codec)
>  static const struct snd_kcontrol_new twl4030_snd_controls[] = {
>  	SOC_DOUBLE_R("Master Playback Volume",
>  		 TWL4030_REG_ARXL2PGA, TWL4030_REG_ARXR2PGA,
> -		0, 127, 0),
> +		0, 0x3f, 0),
>  	SOC_DOUBLE_R("Capture Volume",
>  		 TWL4030_REG_ATXL1PGA, TWL4030_REG_ATXR1PGA,
> -		0, 127, 0),
> +		0, 0x1f, 0),
>  };
>  
>  /* add non dapm controls */
> -- 
> 1.6.0.3
> 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

-- 
"You grabbed my hand and we fell into it, like a daydream - or a fever."


More information about the Alsa-devel mailing list