[alsa-devel] Mute Beep (was Regression on alsa-driver-1.0.18a on HDA for Dell Inspiron 1521)

[Takashi Iwai]

At Fri, 14 Nov 2008 00:16:41 -0200,
Manuel Naranjo wrote:
> 
> > FWIW, I already merged the patches to my git tree.
> > So the latest snapshot should have already this.
> >   
> Takashi,
> Sorry for the delayed answer. I tried both by patching my yesterday 
> snapshot, and by using the new snapshot, neither of them worked 
> completly right.
> 
> Good part is that now I can decide if I either want to turn on or off 
> the bloody beep. But result is the same on both cases, no matter if it's 
> on or off it doesn't make a beep (which is pretty good for my ears, but 
> not for the code purspose).

Could you check the debug messages with the patch below?


thanks,

Takashi

---
diff --git a/sound/pci/hda/hda_beep.c b/sound/pci/hda/hda_beep.c
index 3ecd7e7..6693602 100644
--- a/sound/pci/hda/hda_beep.c
+++ b/sound/pci/hda/hda_beep.c
@@ -37,6 +37,8 @@ static void snd_hda_generate_beep(struct work_struct *work)
 		container_of(work, struct hda_beep, beep_work);
 	struct hda_codec *codec = beep->codec;
 
+	printk(KERN_DEBUG "XXX GENERATE BEEP %d\n", beep->enabled);
+
 	if (!beep->enabled)
 		return;
 
@@ -50,6 +52,8 @@ static int snd_hda_beep_event(struct input_dev *dev, unsigned int type,
 {
 	struct hda_beep *beep = input_get_drvdata(dev);
 
+	printk(KERN_DEBUG "XXX BEEP EVENT code=0x%x, hz=%d\n", code, hz);
+
 	switch (code) {
 	case SND_BELL:
 		if (hz)
diff --git a/sound/pci/hda/patch_sigmatel.c b/sound/pci/hda/patch_sigmatel.c
index 58d832c..bb23c04 100644
--- a/sound/pci/hda/patch_sigmatel.c
+++ b/sound/pci/hda/patch_sigmatel.c
@@ -3100,6 +3100,7 @@ static int stac92xx_dig_beep_switch_put(struct snd_kcontrol *kcontrol,
 	int enabled = !!ucontrol->value.integer.value[0];
 	if (codec->beep->enabled != enabled) {
 		codec->beep->enabled = enabled;
+		printk(KERN_DEBUG "XXX BEEP SW %d\n", codec->beep->enabled);
 		return 1;
 	}
 	return 0;