[alsa-devel] [PATCH] ALSA SOC driver for s3c24xx with uda1341

[Russell King - ARM Linux]

On Mon, Nov 10, 2008 at 01:34:52PM +0000, Mark Brown wrote:
> > +	xtal = clk_get(NULL, "xtal");
> > +	pclk = clk_get(NULL, "pclk");
> 
> This should be done in the init function for the device and should
> really check the return value in case it can't get the clock for some
> reason.  Ideally there'd be a dev there, but I'd need to check if the
> s3c24xx stuff does that.

And should not be passing a NULL device to clk_get().