[alsa-devel] [PATCH] ALSA SOC driver for s3c24xx: 8 bit sound fix

[chri]

Hi,

On Mon, Nov 10, 2008 at 7:50 AM, Takashi Iwai <tiwai at suse.de> wrote:
> At Sat,  8 Nov 2008 08:44:16 +0100,
>
> I don't think it's good to overwrite the global variables in this way.
>

I see. I just tried to keep the modifications minimal. Perhaps Ben
Dooks, the author of the code, can suggest a better way to proceed. I
will be happy to follow his suggestion.

> And, what if playback and capture use the different formats in full
> duplex streams...?
>

I dont' think that this is possible on the S3C24{1,4}0 since the
configuration registers are shared between playback and record path
(so this applies to sample frequency too for example). I guess you are
suggesting that given parameters should be checked against those of
the currently playing stream to see if they are compatible?


-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."