On Wed, Nov 05, 2008 at 09:35:01PM +0100, Takashi Iwai wrote: > Mark Brown wrote: > > + if (1) { > For what? That should be an ifdef DEBUG - sorry, looks like I've sent an old version of the patch. My bad, sorry. Troy, when addressing Takashi's other comments please send an incremental patch.