[alsa-devel] [PATCH] ASoC: Clarify API for bias configuration

[Mark Brown]

On Mon, May 19, 2008 at 05:15:58PM +0300, Jarkko Nikula wrote:

> First impression: Is that somewhat confusing to refer power state event
> as a bias level? First what comes to my is this related to mic bias...

Bias here is being used to refer to general DC offset levels on the AC
inputs and outputs of the chip - microphone bias is just one of these
levels.  For a lot of codecs there's no or limited control of the baises
but some do provide fine grained control.

> If there's a need to change name of dapm_event callback, probably some
> dapm_device_event etc. would be better if need to separate from other
> dapm events?

Well, part of the goal was to make it clearer what sort of thing was
expected to be configured by this function.  I'm drawing a bit of a
blank on a better name right now, though.

The tlv320aicx driver is fairly unusual in controlling the PLL here,
though it shouldn't cause any problems either.  Incidentally, it looks
like this needs updating to reflect the support that was added for
bypassing the PLL - presumably if the PLL is bypassed then enabling it
during playback and record will consume power needlessly?

Most drivers expose clocking configuration like the PLL to machine
drivers in order to allow use of clocks generated on the codec
independently of the audio stream - if it's not needed outside of
playback then generally it'd be set up in hw_params() and stopped in
hw_free() or shutdown() to achieve a similar effect to what you're
doing.