[alsa-devel] [PATCH] Support for Roland SonicCell sound module

[Takashi Iwai]

At Mon, 19 May 2008 09:11:36 -0400,
Chris Mennie wrote:
> 
> On Monday 19 May 2008 6:30:00 am Takashi Iwai wrote:
> > Chris Mennie wrote:
> > > 	I'm not sure if this is the right place for it, but I've added support
> > > for the Roland SonicCell sound module. Patches were made against
> > > alsa-driver-1.0.16 source. Please let me know if there's a better place
> > > to post this:
> >
> > The patch looks fine.  Could you give your sign-off for merging to the
> > upstream together with a changelog?
> 
> 	I'm certainly happy with donating the code (if that's what you're 
> asking?) :). As for a changelog entry, I suggest:
> 
> 	usb-audio: Added support for Roland SonicCell

Well, usually the patch must be signed off by the author to be merged
to the upstream for avoiding possible legal and other problems.
See Documentation/SubmittingPatches in Linux kernel tree for details.

About the changelog, I prefer a bit more descrictive one.

Thanks,

Takashi