[alsa-devel] [PATCH 1/3] soc - S3C2410 pcm - Update for changed s3c2410 DMA API change

Mark Brown broonie at opensource.wolfsonmicro.com
Mon May 5 14:13:58 CEST 2008


From: ing. Davide Rizzo <davide at elpa.it>

S3C2410 pcm doesn't work.
s3c2410_dma_request() now returns the channel number and not 0 if OK.
Davide

This patch to update to a s3c2410_dma_request return value change

Signed-off-by: Davide Rizzo <davide at elpa.it>
Acked-by: Liam Girdwood <lg at opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>
---
 sound/soc/s3c24xx/s3c24xx-pcm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/s3c24xx/s3c24xx-pcm.c b/sound/soc/s3c24xx/s3c24xx-pcm.c
index 6c70a81..7806ae6 100644
--- a/sound/soc/s3c24xx/s3c24xx-pcm.c
+++ b/sound/soc/s3c24xx/s3c24xx-pcm.c
@@ -171,7 +171,7 @@ static int s3c24xx_pcm_hw_params(struct snd_pcm_substream *substream,
 		ret = s3c2410_dma_request(prtd->params->channel,
 					  prtd->params->client, NULL);
 
-		if (ret) {
+		if (ret < 0) {
 			DBG(KERN_ERR "failed to get dma channel\n");
 			return ret;
 		}
-- 
1.5.5.1



More information about the Alsa-devel mailing list