[alsa-devel] PXA2xx/3xx AC97 Driver(s)

[Russell King - ARM Linux]

On Mon, Mar 24, 2008 at 01:42:32PM +0000, Mark Brown wrote:
> On Mon, Mar 24, 2008 at 12:38:00PM +0000, Oliver Ford wrote:
> > but am not sure. Compiling either gives the warning "'pxa_set_cken' is 
> > deprecated". I suspect calling this won't work for the pxa310 since it's 
> 
> This is also fixed in the patches currently queued in the ARM tree -
> the drivers have been converted to use the clk_() API.
> 
> > clocks are different, but given that I'm booting linux from windows 
> > (which will leave the clock on) and don't particularly care about 
> > suspend/resume, should not being able to switch it off be a problem?
> 
> The cken calls should actually work fine.

The pxa_set_cken() will not do the right thing for PXA3xx CPUs, which is
why that interface is deprecated.  If you're building for PXA3 CPUs and
you get warnings about pxa_set_cken() that's a sure sign that something's
wrong.