[alsa-devel] [PATCH] [ML403-AC97CR] Remove duplicate snd_card_set_dev().
Takashi Iwai
tiwai at suse.de
Mon Mar 17 08:42:28 CET 2008
At Sat, 15 Mar 2008 10:43:09 +0100,
Joachim Foerster wrote:
>
> Hi Takashi,
>
> I noticed, that there was a change in ml403-ac97cr.c, which introduces a
> second call of snd_card_set_dev() in the _probe()-function. The
> "original" one is in the snd_ml403_ac97cr_create()-function.
>
> According the other changes, I guess, we want to have it in the
> _probe()-function, now (=> following patch)?
It's no big matter whether it's set. The only requirement is that
it must be called before registering the device, typically via
snd_card_register().
> From: Joachim Foerster <JOFT at gmx.de>
>
> We want to have snd_card_set_dev() in _probe(), but not a second one in
> snd_ml403_ac97cr_create().
>
> Signed-off-by: Joachim Foerster <JOFT at gmx.de>
Applied to ALSA tree. Thanks.
Takashi
More information about the Alsa-devel
mailing list