[alsa-devel] [PATCH 1/3] ASoC: Add WM8510 driver

[Takashi Iwai]

At Wed, 4 Jun 2008 20:24:56 +0100,
Mark Brown wrote:
> 
> > Also, is the patch author you or Liam?
> 
> We've both worked on the driver; Liam did the original driver and I've
> done some fairly invasive changes to it since then, particularly to the
> input paths.  The Author: is showing as me since that's what git did
> when I pulled the driver over into mainline for submission.

OK.  I just wanted to confirm since the patch had no extra From: line
although the comment in the code shows Liam as the author.


And, I seem to have cut some review comments accidentally during
editing in the previous mail.  Here is again:

> diff --git a/sound/soc/codecs/wm8510.c b/sound/soc/codecs/wm8510.c
(snip)
> +#include <linux/version.h>

This is likely superfluous.

> +#include <sound/initval.h>

Ditto.

> +static int wm8510_init(struct snd_soc_device *socdev)
> +{
> +	struct snd_soc_codec *codec = socdev->codec;
> +	int ret = 0;
> +
> +	codec->name = "WM8510";
> +	codec->owner = THIS_MODULE;
> +	codec->read = wm8510_read_reg_cache;
> +	codec->write = wm8510_write;
> +	codec->set_bias_level = wm8510_set_bias_level;
> +	codec->dai = &wm8510_dai;
> +	codec->num_dai = 1;
> +	codec->reg_cache_size = sizeof(wm8510_reg);

Isn't this ARRAY_SIZE()?  Looks like the all codec codes set the wrong
values for this...


thanks,

Takashi