[alsa-devel] [PATCH] Revised AT32 ASoC Patch

Takashi Iwai tiwai at suse.de
Wed Jun 4 15:51:52 CEST 2008


At Wed, 4 Jun 2008 14:28:07 +0100,
Mark Brown wrote:
> 
> On Wed, Jun 04, 2008 at 02:01:55PM +0200, Takashi Iwai wrote:
> > Geoffrey Wossum wrote:
> 
> > > +struct at32_ssc_info {
> > > +	char *name;
> > > +	struct ssc_device *ssc;
> > > +	spinlock_t lock;	/* lock for dir_mask */
> 
> > Just wondering whether this lock is really needed.
> > Is it really racy?
> 
> Bidirectional ports could be in two PCMs and have configuration
> happening simultaneously.

Fair enough.

But, it's no fast code path, and maybe one global mutex would be
enough for such a purpose, though.


Takashi


More information about the Alsa-devel mailing list