[alsa-devel] [PATCH] pxa2xx-lib: support building for several pxa's

[Dmitry]

Hi,

2008/7/30 Russ Dill <russ.dill at gmail.com>:
> Here's a version of the third patch in the series without all the
> #ifdef's. Just a quick question for Dmitry, why all the if (!
> cpu_is_pxa3xx())'s around the pxa_gpio_mode's? Also, there was a build
> error when just building the sound/arm pxa2xx-ac97.

Good!

AFAIR pxa_gpio_mode isn't valid for the the pxa3xx, so cpu_is_pxa3xx().

>
> Support building pxa2xx-lib for several pxa chip versions by making code
> run-time selected, not only compile-time
>
> Signed-off-by: Russ Dill <russ.dill at gmail.com>
> ---
>  include/asm-arm/arch-pxa/pxa-regs.h |    4 +-
>  sound/arm/Kconfig                   |    2 +-
>  sound/arm/pxa2xx-ac97-lib.c         |  174 ++++++++++++++++------------------
>  sound/soc/pxa/pxa2xx-i2s.c          |   16 ++-
>  4 files changed, 95 insertions(+), 101 deletions(-)
>
-- 
With best wishes
Dmitry