[alsa-devel] [PATCH 1/1] ALSA: Fix limit of 8 PCM devices in SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE

Takashi Iwai tiwai at suse.de
Wed Jul 30 18:37:55 CEST 2008


At Wed, 30 Jul 2008 12:46:40 +0100,
Pawel MOLL wrote:
> 
> ALSA: Fix limit of 8 PCM devices in SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE
> 
> When compiled with CONFIG_SND_DYNAMIC_MINORS the ALSA core is fine
> to have more than 8 PCM devices per card, except one place - the
> SNDRV_CTL_IOCTL_PCM_NEXT_DEVICE ioctl, which will not enumerate
> devices > 7. This patch fixes the issue, changing the devices list
> organisation.
> 
> Instead of adding new device to the tail, the list is now kept always
> ordered (by card number, then device number). Thus, during enumeration,
> it is easy to discover the fact that there is no more given card's
> devices.
> 
> Additionally the device field of struct snd_pcm had to be changed to int,
> as its "unsignednity" caused a lot of problems when comparing it to
> potentially negative signed values. (-1 is 0xffffffff or even more then ;-)
> 
> Signed-off-by: Pawel Moll <pawel.moll at st.com>

Thanks.  Applied this one.


Takashi


More information about the Alsa-devel mailing list