[alsa-devel] [PATCH 10/10] wss_lib: use wss detection code instead of ad1848 one

[Takashi Iwai]

At Tue, 29 Jul 2008 16:15:10 +0200,
Rene Herman wrote:
> 
> > At Mon, 28 Jul 2008 20:39:05 +0200,
> > Rene Herman wrote:
> >> On 28-07-08 17:37, Takashi Iwai wrote:
> >>
> >>> Well, I still prefer folding lines to fit 80-column - of course
> >>> only if the result is somewhat reasonable and more readable.
> >> Which it absolutely never is, because if it were, the original 
> >> programmer would've already formatted it that way.
> > 
> > ... only if the original author respected the standard CodingStyle.
> > Many old ALSA codes are not in that category.
> > 
> > Honestly, I don't mind much to keep them as they are now, even though
> > checkpatch grumbles, if the author (or the heir) wants to keep it
> > intentionally even after reading the CodingStyle text carefully...
> 
> I'm also definitely not speaking about things such as function headers 
> which needlessly walk of to the far right, but specifically about stuff 
> where the formatting _not_ inside 80 cols made things much easier to 
> read. In this case, my specific comments were about:
> 
> 1) mixer element macros
> 
> Many spots in this patchset, but for IMO most clearly bad example:
> 
> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/009272.html
> 
> See the cmi8330 ones.

This kind of change isn't always bad.  The problem is that the
expressions aren't consistent through the whole list.  If the same
style is used for each element, e.g.

WSS_DOUBLE("LONG NAME HERE", 0,
	   LEFT_REG, RIGHT_REG,
	   0, 1, 2, 3),

then it'll be easier to compare each item than before.

A general problem of such macros or functions with many arguments is
that you can loose easily the relationship of each argument, because
they are listed just plainly.  Breaking lines properly could help a
bit.

> Not only do these kind of changes muddy up a patch, they muddy up the 
> result as well. Hate it...
> 
> 2) debug printks
> 
> For one example here, see:
> 
> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/008978.html
> 
> /snd_wss_debug
> 
> Bad, bad, triply bad.

This change is actually buggy.  Each second printk should have no
KERN_* prefix.  KERN_* prefix is only for the beginning of the line.

A more better fix would be to rewrite this to use a loop, BTW.

> 3) trivial switches, although I don't feel hugely strongly about those.
> 
> Example:
> 
> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/009314.html
> 
> /snd_wss_chip_id

This is really trivial and fine to keep in the old way.


thanks,

Takashi