[alsa-devel] [PATCH] Permit simultaneous compilation ofboth PXA AC97 drivers

[Eric Miao]

Yep, I can do all the verfication on all pxa3xx variants and platforms :-)

> -----Original Message-----
> From: Liam Girdwood [mailto:lg at opensource.wolfsonmicro.com]
> Sent: Saturday, July 26, 2008 8:23 PM
> To: Dmitry Baryshkov
> Cc: Mark Brown; alsa-devel at alsa-project.org; Eric Miao; rmk at arm.linux.org.uk
> Subject: Re: [alsa-devel] [PATCH] Permit simultaneous compilation ofboth PXA
> AC97 drivers
> 
> On Sat, 2008-07-26 at 12:06 +0100, Mark Brown wrote:
> > On Sat, Jul 26, 2008 at 02:15:17AM +0400, Dmitry Baryshkov wrote:
> >
> > > I should have said, that these patches are largely untested. Please test
> > > before applying.
> >
> > Yeah, unfortunately it's kind of hard to get good test coverage due to
> > the number of variants :/ .  On the basis of the diffs these patches
> > look good, though the volume of code motion means that I'll do another
> > pass later.  I'll also test with the hardware I have and then push up to
> > Takashi (assuming I don't spot any issues) - it may be the middle of
> > next week before that happens.  Other test reports would be appreciated.
> >
> > This is certainly a very welcome cleanup - thanks a lot for doing it!
> 
> Agreed, thanks for the cleanup. :)
> 
> However this really *must* be tested on all pxa variants before
> upstreaming. The pxa family all have slightly different AC97 controller
> hardware (and quirks) and subsequently it may work fine on your board
> but break others :-/
> 
> We can certainly test on pxa270 and pxa320. Can someone else do the
> other variants.
> 
> Btw, the tests should also include AC97 slot 12 IO. i.e read and write
> codec register 0x54.
> 
> Thanks
> 
> Liam