[alsa-devel] [PATCH] Clean up ASOC functions to support 32b values instead of 16b
Jon Smirl
jonsmirl at gmail.com
Thu Jul 24 06:05:59 CEST 2008
On 7/23/08, Timur Tabi <timur at freescale.com> wrote:
> On Wed, Jul 23, 2008 at 9:08 PM, Jon Smirl <jonsmirl at gmail.com> wrote:
>
> >> Please use "unsigned int" instead of "uint".
> >
> > Why? uint is a standard Linux kernel definition. I almost made them all u32.
>
>
> For consistency. The rest of the source file doesn't use the
> abbreviated types. Also, sized integer types like u32 should only be
> used when the variable must have a certain number of bits, so you
> shouldn't use u32 as a general purpose integer type.
I think I may need to redo this with u32. I'm still working on my
read/write reg routines and it is not obvious that it would adjust
right on a 64b machine. Just because you switch to a 64b machine, my
sound hardware is still 32b.
>
>
> --
>
> Timur Tabi
> Linux kernel developer at Freescale
>
--
Jon Smirl
jonsmirl at gmail.com
More information about the Alsa-devel
mailing list