[alsa-devel] [PATCH] ASoC: Fix warning from strict_strtoul()

[Takashi Iwai]

At Fri,  4 Jul 2008 16:01:14 +0100,
Mark Brown wrote:
> 
> Signed-off-by: Mark Brown <broonie at opensource.wolfsonmicro.com>

Thanks, applied.

(BTW, at the next time, a bit more patch description would be helpful.
 For example, in this case, it's actually not about warning but the
 behavior of strict_strtoul() that resets the value, if I understand
 correctly.)


Takashi

> ---
>  sound/soc/soc-dapm.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index 9e83357..456d78a 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -808,7 +808,11 @@ static ssize_t dapm_pop_time_store(struct device *dev,
>  				   const char *buf, size_t count)
>  
>  {
> -	if (strict_strtoul(buf, 10, &pop_time) < 0)
> +	unsigned long val;
> +
> +	if (strict_strtoul(buf, 10, &val) >= 0)
> +		pop_time = val;
> +	else
>  		printk(KERN_ERR "Unable to parse pop_time setting\n");
>  
>  	return count;
> -- 
> 1.5.6
>