[alsa-devel] [PATCH] hda: Add GPIO mute support to STAC9205

[Takashi Iwai]

At Tue, 29 Jan 2008 09:20:16 -0500,
Matthew Ranostay wrote:
> 
> Takashi Iwai wrote:
> > At Mon, 28 Jan 2008 09:48:00 -0500,
> > Matthew Ranostay wrote:
> >> Support added for detecting HP jack presence via GPIO on several laptop docks.
> >>
> >> Signed-off-by: Matthew Ranostay <mranostay at embeddedalley.com>
> >> ---
> >> diff -r b0d97ac73e0f pci/hda/patch_sigmatel.c
> >> --- a/pci/hda/patch_sigmatel.c	Fri Jan 25 15:24:50 2008 +0100
> >> +++ b/pci/hda/patch_sigmatel.c	Mon Jan 28 09:34:16 2008 -0500
> >> @@ -122,7 +122,9 @@ struct sigmatel_spec {
> >>  	unsigned int alt_switch: 1;
> >>  	unsigned int hp_detect: 1;
> >>  
> >> -	unsigned int gpio_mask, gpio_data;
> >> +	unsigned int gpio_en_mask, gpio_dir_mask;
> >> +	unsigned int gpio_data;
> >> +	unsigned int gpio_mute;
> > 
> > The mask is valid for both dir and data bits.  So I'd like to have the
> > following four fields:
> > 
> > 	unsigned int gpio_mask;
> > 	unsigned int gpio_dir;
> > 	unsigned int gpio_data;
> > 	unsigned int gpio_mute;
> > 
> > (Actually they could be unsigned char on HD-audio.)
> > 
> > Otherwise the patch looks good.
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> 
> Is this what you had in mind?

Exactly.  Thanks.  Now it's on HG tree.


Takashi