[alsa-devel] [PATCH] [ALSA] mpc8610: Add mmap support

[Takashi Iwai]

At Thu, 17 Jan 2008 10:31:37 -0600,
Timur Tabi wrote:
> 
> Alexander E. Patrakov wrote:
> > Timur Tabi wrote:
> >> Enable mmap support in the MPC8610 ASoC driver.  The driver can use 
> >> ALSA's
> >> default mmap functionality, it was just not enabled previously.
> >>
> >> Signed-off-by: Timur Tabi <timur at freescale.com>
> > 
> > [sorry, I may be completely wrong below about the .page callback purpose 
> > - in this case, just confirm that the testcase works]
> > 
> > Hm, the "struct snd_pcm_ops fsl_dma_ops" doesn't contain the .page 
> > callback. With saa7134-alsa, this led to the "device claims to support 
> > mmap but actually doesn't work" bug, see the following subthread:
> 
> Isn't that an ARM chip?  The default MMAP handler in ALSA doesn't support ARM, 
> but it works for PowerPC.
> 
> > http://mailman.alsa-project.org/pipermail/alsa-devel/2007-October/003773.html 
> > 
> > 
> > IOW: have you actually tested that the following commands work (X,Y 
> > refer to the FSL chip)?
> > 
> > aplay -M -D hw:X,Y sample.wav
> > arecord -f cd -M -D:X,Y capture.wav
> 
> I haven't tried record, but I did try playback, and it worked.  Without this 
> patch, adding -M gives me this error:
> 
> aplay: set_params:852: Access type not available
> 
> After applying this patch, playback works fine.

Great, applied to ALSA tree now.

Thanks.

Takashi