[alsa-devel] [PATCH] hda: incorrect DAC mixer on 92hd71bxxx

[Matthew Ranostay]

On Feb 29, 2008, at 5:14 AM, Takashi Iwai wrote:

> At Thu, 28 Feb 2008 17:03:36 -0500,
> Matthew Ranostay wrote:
>>
>> If there was two line_outs[] it would overrun into the dmic nid  
>> struct below
>> and create a phantom "Surround" mixer.
>
> My bad.  But isn't the fix below simpler?
>
Yes it is :)
>
> thanks,
>
> Takashi
>
> ---
> diff -r 54a51b975975 pci/hda/patch_sigmatel.c
> --- a/pci/hda/patch_sigmatel.c	Thu Feb 28 12:46:32 2008 +0100
> +++ b/pci/hda/patch_sigmatel.c	Fri Feb 29 11:17:54 2008 +0100
> @@ -2344,7 +2344,7 @@ static int stac92xx_auto_create_multi_ou
>  	unsigned int wid_caps, pincap;
>
>
> -	for (i = 0; i < cfg->line_outs; i++) {
> +	for (i = 0; i < cfg->line_outs && i < spec->multiout.num_dacs; i+ 
> +) {
>  		if (!spec->multiout.dac_nids[i])
>  			continue;
>
>