[alsa-devel] PATCH: remove duplicate controls in alc268 test

[Jonathan Woithe]

Marco wrote:
> when these four things are missing, alsamixer fails to load, and KMix 
> outputs garbage controls here.
> Would be interesting if other users experience the same.

Why would this be?  These controls are just duplicates of others present
elsewhere in the test mixer structure.  To facilitate the use of the test
mixer it is the "LOUT1 Playback Volume" etc names which should be used which
is why the patch removes the "Front Playback Volume" etc entries.

Does alsamixer/kmix assume that there will always be controls named
"Headphone Playback Volume" and "Front Playback Volume" and crash badly if
they don't exist?  That seems a little odd.

Regards
  jonathan

> > Hi guys
> > 
> > I've just noticed that there are a handful of duplicate controls in the
> > ALC268 test model mixer.  This patch (against alsa-driver 1.0.16) removes
> > them.
> > 
> > Signed-off-by: Jonathan Woithe <jwoithe at physics.adelaide.edu.au>
> > 
> > --- patch_realtek.c-orig	2008-02-05 19:53:24.000000000 +1030
> > +++ patch_realtek.c	2008-02-08 09:23:02.000000000 +1030
> > @@ -9834,11 +9834,6 @@
> >  
> >  #ifdef CONFIG_SND_DEBUG
> >  static struct snd_kcontrol_new alc268_test_mixer[] = {
> > -	HDA_CODEC_VOLUME("Front Playback Volume", 0x2, 0x0, HDA_OUTPUT),
> > -	HDA_CODEC_MUTE("Front Playback Switch", 0x14, 0x0, HDA_OUTPUT),
> > -	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x3, 0x0, HDA_OUTPUT),
> > -	HDA_CODEC_MUTE("Headphone Playback Switch", 0x15, 0x0, HDA_OUTPUT),
> > -
> >  	/* Volume widgets */
> >  	HDA_CODEC_VOLUME("LOUT1 Playback Volume", 0x02, 0x0, HDA_OUTPUT),
> >  	HDA_CODEC_VOLUME("LOUT2 Playback Volume", 0x03, 0x0, HDA_OUTPUT),