[alsa-devel] [PATCH 0/8]ALSA: ASoc: DaVinci: cleanup

[Medisetty, Naresh]

________________________________________
From: Troy Kisky [troy.kisky at boundarydevices.com]
Sent: Friday, December 19, 2008 11:51 PM
To: Mark Brown
Cc: alsa-devel at alsa-project.org; davinci-linux-open-source at linux.davincidsp.com; Medisetty, Naresh
Subject: Re: [alsa-devel] [PATCH 0/8]ALSA: ASoc: DaVinci: cleanup

>
> Mark Brown wrote:
> > On Thu, Dec 18, 2008 at 12:36:38PM -0700, Troy Kisky wrote:
> >
> >> Sorry, for the long series to do something so simple, but there
> >> were unresolved objections when I first posted this to the davinci list.
> >
> > What were the issues people had?
> >
> >> Hopefully, having this split into tiny pieces will make resolving
> >> those differences easier.
> >
> > It certainly makes review easier.
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel at alsa-project.org<mailto:Alsa-devel at alsa-project.org>
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
>
> The meaning change of SND_SOC_DAIFMT_NB_NF was not liked.
> And my comment that I2S mode is not supported on davinci was not
> liked. I'll let Naresh explain.
>



The comment regarding I2S mode is absolutely correct, since the davinci cannot support I2S where the codecs (like TLV320AIC23) has fixed bit clock frequency. Documenting this limitation is a very good idea.

Still I find difficulty to agree with Troy regarding the meaning change of SND_SOC_DAIFMT_NB_NF, since the existing meaning is correct w.r.t davinci McBSP.



> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source at linux.davincidsp.com<mailto:Davinci-linux-open-source at linux.davincidsp.com>
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source