[alsa-devel] [PATCH 5/8] ASoC: TWL4030: DAPM mapping of the PreDriv outputs

[Peter Ujfalusi]

Hello,

On Monday 08 December 2008 13:28:48 ext Mark Brown wrote:
> On Mon, Dec 08, 2008 at 10:09:05AM +0200, Peter Ujfalusi wrote:
> > +static const char *twl4030_predrivel_texts[] =
> > +		{"Off", "DACL1 Switch", "DACL2 Switch", "Invalid",
> > +		"DACR2 Switch"};
>
> Why the "Switch" in the option names - I'd expect to see it omitted.

They will be gone.

> Does the "Invalid" option work well in applications like alsamixer?

Not quite well, the outmixer_event will just plain forbits the Invalid 
combination (returns -1, which should have been -EINVAL). In alsamixer you 
can not really select the "DACR2". With amixer you can.
I have been wondering about this for a while but could not find a better 
solution, yet.

-- 
Péter