[alsa-devel] [patch] alsa-utils check if __USE_BSD is defined before compiling "BSD functions"

[Takashi Iwai]

At Mon, 8 Dec 2008 08:48:48 +0100,
Hans-Christian Egtvedt wrote:
> 
> On Mon, 08 Dec 2008 08:34:55 +0100
> Takashi Iwai <tiwai at suse.de> wrote:
> 
> > At Mon, 8 Dec 2008 07:26:02 +0100,
> > Hans-Christian Egtvedt wrote:
> > > 
> > > Hi,
> > > 
> > > Another bug/issue I tripped over when compiling alsa-utils in an
> > > environment using uClibc to supply the C library functions. Here I
> > > have enabled some old BSD style functions. The attached patch will
> > > honor them if they are enabled.
> > > 
> > > Without this patch I get a redefined error during compile.
> > 
> > Hmm, but with this patch, I get undefined reference errors :)
> >     alsactl/init_sysfs.c:39: undefined reference to `strlcpy'
> >     ....
> > 
> > Checking __USB_BSD seems insufficient, unfortunately.
> > 
> 
> Perhaps it should be UCLIBC specific? Something like
> "&& !(defined(__UCLIBC__) && defined(__USE_BSD))"

Should be fine.  This fix is committed now.

Thanks,

Takashi