[alsa-devel] HD-audio modularization

[Takashi Iwai]

At Wed, 3 Dec 2008 18:05:06 +0100,
=?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> 
> Really? I thought that filename mattered a lot only in cases where
> it's included in many locations/headers, which I hardly doubt being
> the case for patch_sigmatel.c.

It makes harder to keep the change history.  GIT can detect the
rename, but it's not always doing (beacuse it costs time).
Better not to rename a file unless you really need it.


Takashi

> 2008/12/3 Takashi Iwai <tiwai at suse.de>:
> > At Wed, 3 Dec 2008 16:24:42 +0100,
> > =?UTF-8?Q?Vedran_Mileti=C4=87?= wrote:
> >>
> >> I don't like the fact that CONFIG_HDA_CODEC_SIGMATEL produces a module
> >> named hda-codec-idt. All the other modules are named as their config
> >> options. Can you make this one as well?
> >
> > Well, it's now really IDT, and one should avoid the name Sigmatel.
> > So, if this really matters, it's better to rename the kconfig to
> > CONFIG_SND_HDA_CODEC_IDT.  However, then this doesn't match with
> > patch_sigmatel.c.  And renaming the file is a worse option.
> >
> > So, there is no perfect solution.
> >
> >
> > Takashi
> >
> >
> >> 2008/12/3 Takashi Iwai <tiwai at suse.de>:
> >> > At Fri, 28 Nov 2008 11:34:35 +0100,
> >> > I wrote:
> >> >>
> >> >> Hi,
> >> >>
> >> >> since my original diet plan for HD-audio driver isn't going well
> >> >> as expected, I decided the traditional strategy: divide and conquer.
> >> >>
> >> >> The below is the preliminary patch for modularizing snd-hda-intel.
> >> >> Now the codec-specific codes are split into several modules, and
> >> >> loaded automatically on demand.
> >> >>
> >> >> The patch is against the latest sound.git tree:
> >> >>     git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git
> >> >>
> >> >> It's also included in the recent sound-unstable tree, too
> >> >> (topic/hda-modularize branch):
> >> >>     git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable-2.6.git
> >> >>
> >> >> A known issue is that "alsasound stop" may not work with this because
> >> >> of the explicit module refcount without dependency.  But it's a script
> >> >> problem, basically.  The similar problem must be there for snd-aoa,
> >> >> for example, too.
> >> >
> >> > FYI, the hda-modularization patches are now merged to master branch
> >> > on sound git tree.  The snapshot tarball includes this change as well.
> >> >
> >> > Please report if you get any build errors by this.
> >> >
> >> >
> >> > thanks,
> >> >
> >> > Takashi
> >> > _______________________________________________
> >> > Alsa-devel mailing list
> >> > Alsa-devel at alsa-project.org
> >> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >> >
> >>
> >>
> >>
> >> --
> >> Vedran Miletić
> >
> 
> 
> 
> -- 
> Vedran Miletić