[alsa-devel] ASoC: TWL4030 codec: Multiple DAC nameing

[Mark Brown]

On Tue, Dec 02, 2008 at 12:33:07PM +0200, Peter Ujfalusi wrote:

> /* DACs */
> SND_SOC_DAPM_DAC("DACR1", "Right Front Playback",
> 		TWL4030_REG_AVDAC_CTL, 0, 0),
> SND_SOC_DAPM_DAC("DACL1", "Left Front Playback",
> 		TWL4030_REG_AVDAC_CTL, 1, 0),
> SND_SOC_DAPM_DAC("DACR2", "Right Rear Playback",
> 		TWL4030_REG_AVDAC_CTL, 2, 0),
> SND_SOC_DAPM_DAC("DACL2", "Left Rear Playback",
> 		TWL4030_REG_AVDAC_CTL, 3, 0),

> Are these are OK, or should I just use "Right Playback" for both DACR1 and 
> DACR2?

Your current naming is good - if you use only "Right Playback" DAPM
won't be able to distinguish the two audio streams from each other.